Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aliyun #882

Merged
merged 1 commit into from
May 11, 2022
Merged

Update aliyun #882

merged 1 commit into from
May 11, 2022

Conversation

rootmelo92118
Copy link
Collaborator

@rootmelo92118 rootmelo92118 commented May 11, 2022

#869 I followed the suggestion of @IceCodeNew. I add @!cn tag to overseas domain to cooperate with the list generation logic of https://github.com/Loyalsoldier/domain-list-custom .

@rootmelo92118
Copy link
Collaborator Author

@IceCodeNew 這個修正有哪裡不妥嗎?

@IceCodeNew
Copy link
Collaborator

@IceCodeNew 這個修正有哪裡不妥嗎?

我暂时没时间 review,可以等其他人来看看。
如果有什么地方拿不准的,希望能叫上我一起讨论下。

@KevinZonda KevinZonda merged commit 848f555 into v2fly:master May 11, 2022
@rootmelo92118 rootmelo92118 deleted the patch-1 branch May 11, 2022 23:42
github-actions bot added a commit to YW5vbnltb3Vz/domain-list-community that referenced this pull request May 11, 2022
@IceCodeNew
Copy link
Collaborator

IceCodeNew commented May 12, 2022

上班草草看了一眼,这个 pr 我觉得还有很明显的疑问点啊。

aliyuncs.com 下确定只有这些域名吗?其他子域名在这个 PR 之后就包括不到了啊。

@KevinZonda @rootmelo92118

@Loyalsoldier
Copy link
Collaborator

aliyun 在中国大陆可访问,默认应该直连。建议在此列表保留 aliyuncs.com 这个域名,但是为在国外使用的子域名添加 @!cn 标签。这样,希望 aliyuncs.com 部分海外子域名走代理的用户,可通过配置 geosite:aliyun@!cn 走代理。

@IceCodeNew
Copy link
Collaborator

对,我觉得删除 aliyuncs.com 是有问题的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants